-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Liberation: Add a data liberation handbook setup #374
Conversation
This requires that the site be running the 'Handbook' and 'Wporg Markdown' plugins.
I don't think cron tasks work correctly in the local environment, so you'll probably have to run them manually when required:
|
Just noting, if we want to commit/deploy this prior to resolving all style issues, and as a result have the
Additionally, we probably also want to add a check in here that only loads it for not-rosetta sites, as we currently have no way to translate handbooks (which is a separate issue, and this is not going to resolve) edit: in retrospect, just not enabling the handbook plugin on rosetta will result in that, so nevermind! |
The only question I have is the url structure. We currently have I imagine we could change
I don't know that the following reads that well:
However we do need the following:
So maybe it makes sense to make |
Yeah I wasn't sure on that either :) The good news is that we can change the base slug easily. Currently the PR for the handbook simply sets Based on the WordPress/data-liberation contents, it might make sense to split it up into a few different "sections" of content, based on the intention of the underlying guide:
so something like:
|
This PR adds the necessary things to the theme to support the import of the data liberation guides as a handbook.
See WordPress/data-liberation#46 for the manifest it uses.